Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Upgrade EUI to v31.3.0 (#88881) #89235

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[7.x] Upgrade EUI to v31.3.0 (#88881) #89235

merged 2 commits into from
Jan 26, 2021

Conversation

chandlerprall
Copy link
Contributor

Backports the following commits to 7.x:

@chandlerprall @elizabetdev @kibanamachine
Upgrade EUI to v31.3.0 (elastic#88881)
3761628 
* Bump EUI to v31.3.0

* jest snapshot updates

* Fixed space issue in kbnQueryBar date picker

* Removed unecessary space in query bar scss

Co-authored-by: miukimiu <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kertal
Copy link
Member

kertal commented Jan 26, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

has Kibana index patterns in the options.Sourcerer Default scope has Kibana index patterns in the options

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `button.euiFilterSelectItem[title="metrics-*"]`, but never found it. Queried from element: <div.euiPanel.euiPanel--borderRadiusMedium.euiPanel--plain.euiComboBoxOptionsList.euiPopover__panel.euiPopover__panel-isAttached.euiPopover__panel-noArrow.euiPopover__panel-isOpen.euiPopover__panel--bottom>
    at eval (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15952:14)
at Array.every (<anonymous>)
    at Object.isSourcererOptions (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15949:25)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15043:25)
selected KIP gets added to sourcerer.Sourcerer Default scope selected KIP gets added to sourcerer

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `button.euiFilterSelectItem[title="metrics-*"]`, but never found it. Queried from element: <div.euiPanel.euiPanel--borderRadiusMedium.euiPanel--plain.euiComboBoxOptionsList.euiPopover__panel.euiPopover__panel-isAttached.euiPopover__panel-noArrow.euiPopover__panel-isOpen.euiPopover__panel--bottom>
    at Object.selectSourcererOption (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15961:21)
    at Object.setSourcererOption (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15989:13)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15046:25)
does not return data without correct pattern selected.Sourcerer Default scope does not return data without correct pattern selected

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `button.euiFilterSelectItem[title="metrics-*"]`, but never found it. Queried from element: <div.euiPanel.euiPanel--borderRadiusMedium.euiPanel--plain.euiComboBoxOptionsList.euiPopover__panel.euiPopover__panel-isAttached.euiPopover__panel-noArrow.euiPopover__panel-isOpen.euiPopover__panel--bottom>
    at Object.selectSourcererOption (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15961:21)
    at Object.setSourcererOption (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15989:13)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/data_sources/sourcerer.spec.ts:15053:25)

and 2 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.5MB 7.5MB +74.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 801.0KB 801.1KB +24.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 673.9KB 675.3KB +1.4KB
[email protected] 2.4MB 2.4MB +7.0KB
total +8.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit a245def into elastic:7.x Jan 26, 2021
@chandlerprall chandlerprall deleted the backport/7.x/pr-88881 branch January 26, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @kertal @kibanamachine